Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-empty project folder confirmation dialog #99787

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 28, 2024

A special dialog opens when you try to create a project in non-empty folder. It will also print

ERROR: Attempting to make child window exclusive, but the parent window already has another exclusive child. This window: /root/@ProjectManager@1100/@ConfirmationDialog@1264, parent window: /root, current exclusive child window: /root/@ProjectManager@1100/@ProjectDialog@737
   at: Window::_set_transient_exclusive_child (C:\godot_source\scene/main/window.cpp:951)

The PR fixes it and also makes the dialog reused, instead of created every time.

@KoBeWi KoBeWi added this to the 4.4 milestone Nov 28, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner November 28, 2024 12:33
@akien-mga akien-mga merged commit 537c05b into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the nonempt_dialog branch November 29, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants