Fix use after free in redo of "Create Custom Bone2D(s) from Node(s)" #99800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. Your Gut identity in this commit is |
Using "queue_free" on the undo of the creation of the Bone2D meant that on the redo the Bone2D was already deleted. Replaced it with "add_do_reference", so when the Action of the undo_redo is destroyed, also destroys the Bone2D.
amarsero
force-pushed
the
bone2d-redo-crash
branch
from
09b931e to
d514ab2
Compare
|
Found the culprit Thanks! |
AThousandShips
changed the title
KoBeWi
approved these changes
Dec 25, 2024
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97652
Using "queue_free" on the undo of the creation of the Bone2D meant that on the redo the Bone2D was already deleted.
Replaced it with "add_do_reference", so when the Action of the undo_redo is destroyed, also destroys the Bone2D.