Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style skeleton button on import screen #99810

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

hakro
Copy link
Contributor

@hakro hakro commented Nov 28, 2024

Fixes #98723

There is no white skeleton svg available currently, so I kept the red one, which is consistent with the Skeleton3D node, so it kinda make sense.
But now, when it's enabled, you get the square backdrop, similar to other toggle buttons in the editor, like the Snap to grid button.

Screenshot_20241128_221511

@hakro hakro requested a review from a team as a code owner November 28, 2024 21:20
@fire fire requested review from a team November 28, 2024 21:54
@Calinou Calinou added this to the 4.4 milestone Nov 28, 2024
@Calinou
Copy link
Member

Calinou commented Nov 28, 2024

There is no white skeleton svg available currently

I made one: AnimationPreview.svg.zip

@hakro
Copy link
Contributor Author

hakro commented Nov 29, 2024

There is no white skeleton svg available currently

I made one: AnimationPreview.svg.zip

Thank you, I brought it in.

@hakro
Copy link
Contributor Author

hakro commented Feb 11, 2025

@Calinou , does this look good for 4.4 ?

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@akien-mga akien-mga merged commit 622344b into godotengine:master Feb 12, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Toggle Animation Skeleton Visibility" enabled/disabled icons appear to be inverted
3 participants