Debounce inspector search to make it more responsive #99812
+67
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Nov 28, 2024
KoBeWi
changed the title
KoBeWi
force-pushed
the
responsible_inspector
branch
from
e3e6f0e to
73908b1
Compare
|
Changed the implementation. I added DebouncedLineEdit, which has this behavior built-in. It's used in the inspector and AssetLibrary search. |
KoBeWi
force-pushed
the
responsible_inspector
branch
from
73908b1 to
a4eeb8c
Compare
KoBeWi
commented
Nov 29, 2024
|
|
||
| void EditorInspector::_filter_changed(const String &p_text) { | ||
| update_tree(); | ||
| search_box = Object::cast_to<LineEdit>(p_line_edit); |
There was a problem hiding this comment.
I don't get why this method takes Node, but I kept support for the old behavior just in case.
KoBeWi
force-pushed
the
responsible_inspector
branch
from
a4eeb8c to
b935e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
godot.windows.editor.dev.x86_64_FG8l5EsZBZ.mp4
I'm writing text, but the editor is frozen as I'm writing, because the inspector updates with every letter. The text just appears in the end.
After
godot.windows.editor.dev.x86_64_NhySnNcxPO.mp4
You can actually see that I'm typing something.
The issue is a bit exaggerated, because it's a dev build, but it's still noticeable problem in official release. The PR adds a debounce timer, so the inspector won't search (and destroy/rebuild whole tree) every time you add a letter.