Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Event Configuration dialog wider and its input list taller for better usability #99829

Merged

Conversation

miv391
Copy link
Contributor

@miv391 miv391 commented Nov 29, 2024

Fixed some usability problems in Event Configuration dialog:

  • If the event name, e.g. "Joypad Button 0 (Bottom Action, Sony Cross, Xbox A, Nintendo B) - All Devices" does not fit on one line, the name label wraps the name to second line, causing the listbox containing inputs changing its location. This happening when clicking an input is quite distracting.
  • The vertical size of the action listbox is quite small. When action is selected, some additional information is displayed at the bottom, making the listbox even smaller. If at the same time the event name is wrapped, you can see only 4 lines of information in the listbox.

Changes:

  • Event Configuration dialog is now wider. Event name wrapping should now be much more rare.
  • Action Tree is now taller.

The Event Configuration dialog is still smaller than its parent dialog (Project Settings), so I don't think that making the dialog larger will cause any problems.

Master:
master

This PR:
this-pr

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog is still smaller than the parent settings dialog, so bigger size won't be a problem. Makes sense to increase it.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.4 Dec 25, 2024
@Repiteo Repiteo merged commit 3bf4541 into godotengine:master Dec 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 30, 2024

Thanks!

@miv391 miv391 deleted the larger_event_configuration_dialog branch December 31, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants