Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy EditorFilesystem/EditorSettings on test shutdown #99847

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

demolke
Copy link
Contributor

@demolke demolke commented Nov 29, 2024

Otherwise asan complains if a test tries to use these.

Split off from #98909

@demolke demolke changed the title Destroy EditorPaths/EditorSettings on test shutdown Destroy EditorFilesystem/EditorSettings on test shutdown Nov 30, 2024
@akien-mga
Copy link
Member

Needs a rebase to pass CI, I had made a bit of a mess on Friday evening.

Otherwise asan complains if a test tries to use these.

Split off from godotengine#98909
@demolke
Copy link
Contributor Author

demolke commented Dec 2, 2024

Did the rebase - @pafuent looks like the tests introduced in #97262 are flaky on Mac, because sometimes they pass and sometimes they don't.

My change at the same commit
Passed in my project - https://github.com/demolke/godot/actions/runs/12126549905
Failed in GodotEngine - https://github.com/godotengine/godot/actions/runs/12126550499/job/33808899066

Some other recent runs that have experienced the same issue.
https://github.com/godotengine/godot/actions/runs/12107826446/job/33755156287
https://github.com/godotengine/godot/actions/runs/12095018759/job/33727746905
https://github.com/godotengine/godot/actions/runs/12094971735/job/33728735457

@pafuent
Copy link
Contributor

pafuent commented Dec 2, 2024

I'll take a look at it tonight. I developed those tests on a Mac and I never saw that test being flaky. Hopefully it will be easy to reproduce it locally running it in a loop. Sorry for the inconveniences.

@pafuent
Copy link
Contributor

pafuent commented Dec 3, 2024

Fixed in #99960

@Repiteo Repiteo merged commit 781c6a8 into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks!

@demolke demolke deleted the editorpaths branch December 3, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants