-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroy EditorFilesystem/EditorSettings on test shutdown #99847
Conversation
Needs a rebase to pass CI, I had made a bit of a mess on Friday evening. |
Otherwise asan complains if a test tries to use these. Split off from godotengine#98909
Did the rebase - @pafuent looks like the tests introduced in #97262 are flaky on Mac, because sometimes they pass and sometimes they don't. My change at the same commit Some other recent runs that have experienced the same issue. |
I'll take a look at it tonight. I developed those tests on a Mac and I never saw that test being flaky. Hopefully it will be easy to reproduce it locally running it in a loop. Sorry for the inconveniences. |
Fixed in #99960 |
Thanks! |
Otherwise asan complains if a test tries to use these.
Split off from #98909