Fix language server causing random crashes when use_threads is enabled
#99861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-000
force-pushed
the
Fix-language-server-thread-crash
branch
from
e6a4c17 to
1fb39a0
Compare
adamscott
reviewed
Nov 30, 2024
Ryan-000
force-pushed
the
Fix-language-server-thread-crash
branch
from
1aaab5a to
3439575
Compare
adamscott
approved these changes
Dec 1, 2024
AThousandShips
approved these changes
Dec 1, 2024
Ryan-000
force-pushed
the
Fix-language-server-thread-crash
branch
from
141c6ae to
c3d1ff0
Compare
Co-Authored-By: Adam Scott <ascott.ca@gmail.com> Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Ryan-000
force-pushed
the
Fix-language-server-thread-crash
branch
from
c3d1ff0 to
8dd330d
Compare
adamscott
changed the title
use_threads is enabled
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a few years, I’ve been experiencing random crashes in VS Code when saving GDScript files, and after a long time troubleshooting, I finally found the root cause.
The issue was that
ScriptEditor::reload_scriptswas being called directly on the language server thread whennetwork/language_server/use_threadwas enabled. This led to race conditions that would eventually cause the crashes.