Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildsystem: Include icu4c into ft_linked_deps check #99883

Closed
wants to merge 1 commit into from

Conversation

j20001970
Copy link
Contributor

Closes #91401

Building freetype, libpng, zlib, graphite, harfbuzz as system-provided while leaving icu4c as built-in leads to editor crash when loading GDExtension libraries that uses std::call_once in static initialization. By including builtin_icu4c into ft_linked_deps check, these libraries as a whole, will be either built-in or system-provided.

@j20001970 j20001970 requested a review from a team as a code owner November 30, 2024 19:02
@akien-mga akien-mga changed the title Buildsystem: include icu4c into ft_linked_deps check Buildsystem: Include icu4c into ft_linked_deps check Nov 30, 2024
@Chaosus Chaosus added this to the 4.4 milestone Dec 1, 2024
@j20001970
Copy link
Contributor Author

There is a known bug (#100301) that breaks writing to stdout from GDExtension, it will affect Godot builds that use icu4c as system-provided if this get merged.

Closing this in favor of #100052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants