Fix loading layout with floating dock in single window mode and fix restore_windows_on_load
#99904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix restore_windows_on_load setting preventing loading layouts with floating docks
KoBeWi
approved these changes
Dec 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In single window mode, the dock will instead be docked and not floating.
To reproduce:
It causes the UI to be messed up:
It also prints errors like:
editor/window_wrapper.cpp:222 - Condition "!is_window_available()" is true.Also fixes
restore_windows_on_loadpreventing loading floating docks in a layout when false.This setting should only affect the behavior when the editor is opened, and should not prevent floating windows when loading a layout (in multi-window mode).
To reproduce, disable the setting and load a layout with a floating dock.