Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tooltips from all editor modes inform about the selection menu shortcut #99949

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YeldhamDev
Copy link
Member

As highlighted by #99795 (comment), the tooltips for modes in the Node 3D editor already tell you about the menu selection shortcut, so having the "(Available in all modes.)" in the Selection mode tooltip was pointless. So this PR:

  • Removes "(Available in all modes.)" note in the Selection mode tooltip.
  • Makes the modes in the CanvasItem editor tell you about the shortcut, to match the 3D editor.
  • Removes unnecessary tooltips that are just repeating what the shortcut is saying (small bonus).

Fun fact: the original notes about the shortcut in the 3D editor erroneously said that it showed locked nodes, which wasn't the case before that PR, and is something that I forgot to document on it (oops). But since people thought that's how it worked anyways, no harm done I guess? 😜

Copy link
Contributor

@ryevdokimov ryevdokimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@YeldhamDev YeldhamDev force-pushed the be_more_descriptive_but_also_a_little_less branch from a167ce5 to 240b423 Compare December 24, 2024 07:28
@KoBeWi
Copy link
Member

KoBeWi commented Jan 12, 2025

Removes unnecessary tooltips that are just repeating what the shortcut is saying (small bonus).

So as it turns out, which is probably why we have a check for tooltip matching the shortcut name, if a button has an empty shortcut, it will not show any tooltip at all.

godot.windows.editor.dev.x86_64_GmMNZaNYYm.mp4

With default shortcut removed:

TeY38A51vC.mp4

I'd leave that for another PR, as it requires some re-thinking of the behavior. You can however tweak the tooltips to match shortcut names for buttons that don't already.

There's also this:
image
But there is no way to solve that right now.

EDIT:
I opened #101468
If it's merged first, this PR can be merged without further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants