Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extensions when saving resource as #99987

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix extensions when saving resource as #99987

merged 1 commit into from
Dec 5, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 3, 2024

EditorNode::save_resource_as() creates a list of "preferred" extensions from all available extensions, but then it wasn't used properly.

Fixes #34080

@KoBeWi KoBeWi added this to the 4.4 milestone Dec 3, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner December 3, 2024 21:57
akien-mga
akien-mga approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me.

@Repiteo Repiteo merged commit 4adf4bf into godotengine:master Dec 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 5, 2024

Thanks!

@KoBeWi KoBeWi mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Saving built-in script as file suggest tres extension
4 participants
@KoBeWi @Repiteo @fire @akien-mga