Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize batch uniform set creation by caching ptrw when creating batch uniform #99995

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Optimize batch uniform set creation by caching ptrw when creating batch uniform #99995

merged 1 commit into from
Dec 9, 2024

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Dec 4, 2024

This makes a very small difference, but it is worth doing as the cost of creating these uniform sets can be expensive, so every little bit counts.

@clayjohn clayjohn added this to the 4.4 milestone Dec 4, 2024
@clayjohn clayjohn requested a review from a team as a code owner December 4, 2024 01:18
akien-mga
akien-mga approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems trivial, and makes sense in such a hot path.

stuartcarnie
stuartcarnie approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is a little less noisy, which is also nice.

@Repiteo Repiteo merged commit 75a425f into godotengine:master Dec 9, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartcarnie stuartcarnie stuartcarnie approved these changes

@akien-mga akien-mga akien-mga approved these changes

@Ansraer Ansraer Ansraer approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@clayjohn @Repiteo @stuartcarnie @akien-mga @Ansraer