Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufbx: Update to upstream 0.15.0 #99999

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Dec 4, 2024

Note: I haven't tested or reviewed changes yet, I just needed to make a few PRs quickly for... reasons :P

@akien-mga akien-mga requested a review from a team as a code owner December 4, 2024 01:23
@akien-mga akien-mga added this to the 4.4 milestone Dec 4, 2024
@akien-mga akien-mga requested review from fire and removed request for a team December 4, 2024 01:24
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My strategy is to assume that upstream is correct, merge promptly, and let the ecosystem test.

Sometimes, I test one model.

https://sketchfab.com/3d-models/shibahu-2e9dffd948f747668609a5a477daad86

(I had to set the pictures manually.)

image

Copy link
Contributor

@Chubercik Chubercik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it captain 🥳

@Repiteo Repiteo merged commit 755f600 into godotengine:master Dec 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants