github.com/docker/docker checksum mismatch

[dariusz-przada]

Describe the Bug
I'm using your package in my project together with go modules. Since today (this wasn't happening before) I'm struggling with issue related to github.com/docker/docker checksum. Looks like in your go.sum file there is a wrong checksum for that dependency. Seems like github.com/docker/docker was replaced with https://github.com/moby/moby.

Steps to Reproduce
Steps to reproduce the behavior:

1. In my go.mod file I have: github.com/golang-migrate/migrate/v4 v4.1.0
2. Run "go mod download"

Stacktrace

go: verifying github.com/docker/docker@v0.7.3-0.20180221142240-453f2b8b40b9: checksum mismatch
downloaded: h1:T9/p6Tf8lgB+fBZRwUCn1/b0w8w2/xT2Lsi6SPVp7OU=
go.sum:     h1:j5P9Aya3JMe0sv7rAfRWIohQVP3YxHgui125drv1DAM=

[fsouza]

See golang/go#29278

[dhui]

Fixed by 2417646
I'll wait at least a week before cutting a new release.
If you're blocked by this issue, using the master branch should unblock you.

I'm pretty sure this change isn't backwards compatible since Go 1.11.3 will generate the a different checksum than Go 1.11.4
Not sure how this affects Go 1.10.x

[dhui]

Fixed by v4.2.0

[coolaj86]

This appears to not be fixed, actually:

git clone git@github.com:golang-migrate/migrate.git
pushd migrate

aj@bowie ~/g/migrate> go version
go version go1.11.4 darwin/amd64

aj@bowie ~/g/migrate> go mod tidy

aj@bowie ~/g/migrate> git diff
diff --git a/go.sum b/go.sum
index bf267b4..ffd2f0a 100644
--- a/go.sum
+++ b/go.sum
@@ -43,7 +43,7 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/docker/distribution v0.0.0-20180720172123-0dae0957e5fe h1:ZRQNMB7Sw5jf9g/0imDbI+vTFNk4J7qBdtFI5/zf1kg=
 github.com/docker/distribution v0.0.0-20180720172123-0dae0957e5fe/go.mod h1:J2gT2udsDAN96Uj4KfcMRqY0/ypR+oyYUYmja8H+y+w=
-github.com/docker/docker v0.7.3-0.20180221142240-453f2b8b40b9 h1:T9/p6Tf8lgB+fBZRwUCn1/b0w8w2/xT2Lsi6SPVp7OU=
+github.com/docker/docker v0.7.3-0.20180221142240-453f2b8b40b9 h1:j5P9Aya3JMe0sv7rAfRWIohQVP3YxHgui125drv1DAM=
 github.com/docker/docker v0.7.3-0.20180221142240-453f2b8b40b9/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
 github.com/docker/go-connections v0.4.0 h1:El9xVISelRB7BuFusrZozjnkIM5YnzCViNKohAFqRJQ=
 github.com/docker/go-connections v0.4.0/go.mod h1:Gbd7IOopHjR8Iph03tsViu4nIes5XhDvyHbTtUxmeec=

Linking with moby/moby#38507

[coolaj86]

I'm not sure why the checksum is changing in that go.sum, but it does seem that once I deleted my project go.sum (and let it regenerate from go build) it stopped caring.

So nevermind... maybe?