portPicker function now takes group name #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to set this function
This was referenced Aug 3, 2016
| // called exactly once, but not both. | ||
| func RegisterPerGroupPeerPicker(fn func(groupName string) PeerPicker) { | ||
| if portPicker != nil { | ||
| panic("RegisterPeerPicker called more than once") |
There was a problem hiding this comment.
Misleading panic text. It implies that just RegisterPeerPicker called more that once, while in reality it was RegisterPerGroupPeerPicker called twtice or both RegisterPeerPicker & RegisterPerGroupPeerPicker called. It can be even worse inside the RegisterPeerPicker() - people will try to search for duplicate RegisterPeerPicker() calls while it was RegisterPeerPicker() + RegisterPerGroupPeerPicker().
There was a problem hiding this comment.
Okay, I'll address this in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With RegisterPerGroupPeerPicker added to register a function of this type. Useful for choosing a PeerPicker based on the group.