Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clear methods to lru cache #76

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Conversation

dakerfp
Copy link
Contributor

@dakerfp dakerfp commented Nov 29, 2016

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dakerfp
Copy link
Contributor Author

dakerfp commented Nov 29, 2016

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@@ -119,3 +119,15 @@ func (c *Cache) Len() int {
}
return c.ll.Len()
}

// Clear purges all stored items from the cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end in a period.

Copy link
Contributor Author

@dakerfp dakerfp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period added.

@dakerfp
Copy link
Contributor Author

dakerfp commented Dec 22, 2016

Is there anything else I can do?

@bradfitz
Copy link
Contributor

Squash your two commits down into one.

@dakerfp
Copy link
Contributor Author

dakerfp commented Jan 3, 2017

Done.

@bradfitz bradfitz merged commit 6159c0a into golang:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants