Implement WriterTo #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was looking to write the byteview to a writer and the interface provides |
bradfitz
reviewed
Feb 24, 2017
byteview.go
Outdated
| func (v ByteView) WriteTo(w io.Writer) (int64, error) { | ||
| b := v.b | ||
| if b == nil { | ||
| b = []byte(v.s) |
There was a problem hiding this comment.
but this is an allocation.
Maybe you want to use io.WriteString instead?
There was a problem hiding this comment.
Ah - I'm still learning what allocates and what doesn't. Thanks for pointing that out.
|
hi @bradfitz, checking in, is there anything else you'd like me to correct or think about improving for this cl? |
Avoids allocation/copy when writing byteview to a writer.
|
Hi @bradfitz, checking in again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids allocation/copy when writing byteview to a writer.