feat: add onSync callback to resolve #87 #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new behavior
add
onSync
callback toScrollBar
comp.why
the reason is that I think it is better to decouple the implementation of how to sync perfect-scroll container by invoking
ps.update()
withDI
pattern. In this way, we don't need to expose severalprops
which stand for some special meaning, eg:debounceUpdate
,debounceTime
,debounceMaxTime
and so on. We passps
instance to user and let them decide how to sync the container(even not by involingps.update()
).how to use it
please refer to
example.js