Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install FindPFM.cmake for bencmarkConfig.cmake #1942

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

parona-source
Copy link
Contributor

@parona-source parona-source commented Mar 4, 2025

There is no upstream PFM cmake package config file to use, so this has to be installed for the benchmark cmake package config file to work.

Bug: https://bugs.gentoo.org/950573
See-Also: c214639

$ bash cmake_check.sh /usr/lib64/cmake/benchmark
Temporary directory: /tmp/cmake-test.8nbt
/usr/lib64/cmake/benchmark/benchmarkConfig.cmake
CMake Error at /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "FindPFM.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "PFM", but
  CMake did not find one.

  Could not find a package configuration file provided by "PFM" with any of
  the following names:

    PFMConfig.cmake
    pfm-config.cmake

  Add the installation prefix of "PFM" to CMAKE_PREFIX_PATH or set "PFM_DIR"
  to a directory containing one of the above files.  If "PFM" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  /usr/lib64/cmake/benchmark/benchmarkConfig.cmake:26 (find_dependency)
  CMakeLists.txt:3 (find_package)


Failed with:
cmake_minimum_required(VERSION 3.10)
project(test)
find_package(benchmark REQUIRED CONFIG)

Copy link

google-cla bot commented Mar 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

There is no upstream PFM cmake package config file to use, so this has
to be installed for the benchmark cmake package config file to work.

Bug: https://bugs.gentoo.org/950573
See-Also: c214639
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@dmah42 dmah42 merged commit 571c235 into google:main Mar 5, 2025
84 of 86 checks passed
@dmah42
Copy link
Member

dmah42 commented Mar 5, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants