Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added windows platform support to premake #567

Merged
merged 3 commits into from
Jul 10, 2017
Merged

Conversation

tavrez
Copy link
Contributor

@tavrez tavrez commented Jun 24, 2017

Win32 and Win64 configuration support for visual studio solutions

Win32 and Win64 configuration support for visual studio solutions
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@tavrez
Copy link
Contributor Author

tavrez commented Jun 24, 2017

I've signed CLA

@googlebot
Copy link

CLAs look good, thanks!

@eustas
Copy link
Collaborator

eustas commented Jun 28, 2017

Sorry for the late response. Lets change the order in the platforms list, so Win64 is listed first (and becomes the default).

@eustas
Copy link
Collaborator

eustas commented Jun 28, 2017

Also adding "platform" blows the configuration matrix.
Now for linux/gmake there will be:

  • release_win32
  • release_win64
  • debug_win32
  • debug_win64

Sounds ridiculous. So, lets get rid of "win" prefix.

@eustas
Copy link
Collaborator

eustas commented Jun 28, 2017

There is a nice example how to specify architecture on premake wiki: https://github.com/premake/premake-core/wiki/architecture

@tavrez
Copy link
Contributor Author

tavrez commented Jun 28, 2017

I though that system:"Windows" in filter configurations will make it only available in windows and results won't change anything in linux/gmake.
Thanks for the response and notes, I'll make it better

Fixed platform support for linux, made x64 default
premake5.lua Outdated
@@ -13,6 +14,12 @@ filter "configurations:Release"
filter "configurations:Debug"
flags { "Symbols" }

filter { "platforms:x64" }
architecture "x64"
Copy link
Collaborator

@eustas eustas Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86_64?

premake5.lua Outdated
architecture "x64"

filter { "platforms:x86" }
architecture "x86_64"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86?

@tavrez
Copy link
Contributor Author

tavrez commented Jul 9, 2017

Sorry, seems like VS only care about platform name, not what we write in front of architecture. But I fixed mistypings you mentioned.

@eustas eustas merged commit 5aabc7a into google:master Jul 10, 2017
juj pushed a commit to Unity-Technologies/brotli that referenced this pull request May 13, 2023
* Added windows platform support to premake

Win32 and Win64 configuration support for visual studio solutions

* Update premake5.lua

Fixed platform support for linux, made x64 default

* Update premake5.lua

Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants