-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added windows platform support to premake #567
Conversation
Win32 and Win64 configuration support for visual studio solutions
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I've signed CLA |
CLAs look good, thanks! |
Sorry for the late response. Lets change the order in the platforms list, so Win64 is listed first (and becomes the default). |
Also adding "platform" blows the configuration matrix.
Sounds ridiculous. So, lets get rid of "win" prefix. |
There is a nice example how to specify architecture on premake wiki: https://github.com/premake/premake-core/wiki/architecture |
I though that |
Fixed platform support for linux, made x64 default
premake5.lua
Outdated
@@ -13,6 +14,12 @@ filter "configurations:Release" | |||
filter "configurations:Debug" | |||
flags { "Symbols" } | |||
|
|||
filter { "platforms:x64" } | |||
architecture "x64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x86_64?
premake5.lua
Outdated
architecture "x64" | ||
|
||
filter { "platforms:x86" } | ||
architecture "x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x86?
Fix typo
Sorry, seems like VS only care about platform name, not what we write in front of architecture. But I fixed mistypings you mentioned. |
* Added windows platform support to premake Win32 and Win64 configuration support for visual studio solutions * Update premake5.lua Fixed platform support for linux, made x64 default * Update premake5.lua Fix typo
Win32 and Win64 configuration support for visual studio solutions