Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for more preconditions before deploying #4606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check for more preconditions before deploying #4606

wants to merge 3 commits into from

Conversation

letitz
Copy link
Collaborator

@letitz letitz commented Jan 14, 2025

Specifically:

  • set up application-default gcloud credentials
  • if deploying to k8s, check that kubectl and terraform are in the PATH

@letitz letitz requested a review from vitorguidi January 14, 2025 17:05
vitorguidi
vitorguidi approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jonathanmetzman
jonathanmetzman requested changes Jan 15, 2025
View reviewed changes
src/local/butler/deploy.py
@@ -533,6 +533,9 @@ def execute(args):
_enforce_tests_pass()
_enforce_safe_day_to_deploy()

# Needed for some subsequent steps.
common.execute('gcloud auth application-default login')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...We don't use the gcb deploy so much but I'm not sure this works there. Also does it force me to login each deploy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would force you to log in on each deploy, yes. That was required to deploy to appengine when I tried - the culprit was python butler.py run setup on line 438.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this out please. It might save you some time but it will break out GCB deploy and make things more annoying for me to deploy (particularly because I SSH into the machine I deploy from).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman requested changes

@vitorguidi vitorguidi vitorguidi approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@letitz @vitorguidi @jonathanmetzman