Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ar.toml -Enhance Arabic User Experience with Feedback Labels and Correct Diacritics #2058

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

jadmadi
Copy link
Contributor

@jadmadi jadmadi commented Jul 29, 2024

This pull request introduces Arabic feedback labels with accurate diacritics (Tashkeel) to improve the overall user experience for Arabic speakers.

Key changes:

  • Added Arabic strings for the "feedback" label.
  • Corrected and applied mandatory diacritics to Arabic characters.
  • Implemented the approved Arabic translation of "feedback" as defined by The Digital Arabic Language Hub (https://www.m-a-arabia.com/vb/showthread.php?t=30619).

This update ensures consistency with Arabic language standards and enhances the clarity and readability of the user interface for Arabic-speaking users.

jadmadi added 2 commits July 29, 2024 06:51
…critics and translation

Introduced strings for displaying "feedback" in the Arabic user interface.
Ensured proper mandatory diacritics (Tashkeel) are applied to Arabic characters for clarity.
Utilized the approved translation of "feedback" as provided by The Digital Arabic Language Hub (https://www.m-a-arabia.com/vb/showthread.php?t=30619).
Update ar.toml - Enhance Arabic User Experience with Feedback Labels and Correct Diacritics
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please remove the extra spaces added throughout the file, since in the case of {{...}} directives, it will break the rendering.

@chalin chalin added this to the 24Q3 milestone Aug 5, 2024
@chalin chalin added the i18n Internationalization / Localization label Aug 5, 2024
…critics and translation

Introduced strings for displaying "feedback" in the Arabic user interface.
Ensured proper mandatory diacritics (Tashkeel) are applied to Arabic characters for clarity.
Utilized the approved translation of "feedback" as provided by The Digital Arabic Language Hub (https://www.m-a-arabia.com/vb/showthread.php?t=30619).
@jadmadi jadmadi requested review from deining and chalin August 8, 2024 20:17
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jadmadi
Copy link
Contributor Author

jadmadi commented Aug 11, 2024

@deining Would appreciate reviewing and approving it.

Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadmadi
Copy link
Contributor Author

jadmadi commented Aug 25, 2024

This is a stalled pull request. Should I tag someone, or is it just the regular procedure?

@chalin chalin merged commit 62df879 into google:main Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization / Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants