JDWP overhaul #1733
Merged
JDWP overhaul #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a debug mode which prints every send and recv. Add string helpers for the majority of the message types. Flesh out thread-reference APIs. Reimplement the event request API to be more strict about thread suspension.
AWoloszyn
approved these changes
Mar 8, 2018
pmuetschard
reviewed
Mar 8, 2018
| } | ||
| cmdNames[c] = n | ||
| } | ||
| register(cmdVirtualMachineVersion, "Version") |
There was a problem hiding this comment.
why not just make the name a field in the cmd struct?
There was a problem hiding this comment.
Because if we get a cmdSet and cmdID from somewhere else (say the wire), we can use struct-equality to lookup the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a debug mode which prints every send and recv.
Add string helpers for the majority of the message types.
Flesh out thread-reference APIs.
Reimplement the event request API to be more strict about thread suspension.