Initial scaffolding for profiling replays. #2775
Conversation
| @@ -234,6 +248,11 @@ func (a API) Replay( | |||
| transforms.Add(rf) | |||
| } | |||
|
|
|||
| if profile != nil { | |||
| // Don't use DCE. TODO: should we? | |||
There was a problem hiding this comment.
I don't think we should be using DCE for profiling. It would be way too easy for it to give completely wrong answers.
| @@ -331,6 +352,25 @@ func (a API) QueryFramebufferAttachment( | |||
| return res.(*image.Data), nil | |||
| } | |||
|
|
|||
| func (a API) SupportsPerfetto(ctx context.Context, i *device.Instance) bool { | |||
There was a problem hiding this comment.
It seems like this should be a function of the device, rather than a function of the API.
| @@ -1086,3 +1122,22 @@ func (a API) QueryTimestamps( | |||
| } | |||
| return res.([]replay.Timestamp), nil | |||
| } | |||
|
|
|||
| func (a API) SupportsPerfetto(ctx context.Context, i *device.Instance) bool { | |||
There was a problem hiding this comment.
Same as above, I think we should add this to the device.
|
It's going to take me a bit longer to get through all of the transforms |
| ).AddRead(bufferImageCopyData.Data()) | ||
|
|
||
| out.MutateAndWrite(ctx, id, newCmd) | ||
| default: |
There was a problem hiding this comment.
We should also handle VkCmdBlitImage VkCmdCopyImage
If the image can/would be used as a framebuffer, this may cause problems as well. Likely we should check for VkImageUsageFlagBits_VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT and do nothing, since that would indicate this is a color attachment.
| break | ||
| } | ||
|
|
||
| imageCreateInfo.SetExtent(NewVkExtent3D(s.Arena, newTexWidth, newTexHeight, newTexDepth)) |
There was a problem hiding this comment.
If this is a mipmapped image, we have to adjust mip-levels appropriately.
mipLevels must be less than or equal to the number of levels in the complete mipmap chain based on extent.width, extent.height, and extent.depth.
That means any image-view that is created from this image must also be adjusted so only ever talk about the first mip-level.
There was a problem hiding this comment.
Not sure if we want to do anything about array-layers, I expect we want to at least leave them alone,
| } | ||
| out.MutateAndWrite(ctx, id, newCmd) | ||
| case *VkCmdCopyBufferToImage: | ||
| bufferImageCopy := cmd.PRegions().MustRead(ctx, cmd, s, nil) |
There was a problem hiding this comment.
Mip-levels also have to be handled here.
| height := u32.Min(imageExtent.Height(), newTexHeight) | ||
| depth := u32.Min(imageExtent.Depth(), newTexDepth) | ||
|
|
||
| bufferImageCopy.SetImageExtent(NewVkExtent3D(s.Arena, width, height, depth)) |
There was a problem hiding this comment.
If we are setting the image depth to 1, we have to be careful with the 2-d image view into 3d image.
| l := s.MemoryLayout | ||
| cb := CommandBuilder{Thread: cmd.Thread(), Arena: s.Arena} | ||
| switch cmd := cmd.(type) { | ||
| case *VkCmdSetViewport: |
There was a problem hiding this comment.
The viewport may also be specified in the pipeline creation as a non-dynamic piece of data. We should catch it there as well.
https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#VkPipelineViewportStateCreateInfo
| newCmd.AddWrite(w.Range, w.ID) | ||
| } | ||
| out.MutateAndWrite(ctx, id, newCmd) | ||
| default: |
There was a problem hiding this comment.
You may have to also adjust scissor and renderpasscreateinfo structs for this to remain valid.
https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#VkRenderPassBeginInfo
The application must ensure (using scissor if necessary) that all rendering is contained within the render area. The render area must be contained within the framebuffer dimensions.
| isIndirectDraw := false | ||
| var cmdBuf VkCommandBuffer | ||
| switch cmd := cmd.(type) { | ||
| case *VkCmdDraw: |
There was a problem hiding this comment.
My only worry about this transform is that drawing partial primitives is not well-defined. As in the draw call has to not crash, but the driver is free to simply drop the entire call (if ALL primitives are partial).
| l := s.MemoryLayout | ||
| cb := CommandBuilder{Thread: cmd.Thread(), Arena: s.Arena} | ||
| switch cmd := cmd.(type) { | ||
| case *VkCreateShaderModule: |
There was a problem hiding this comment.
You are allowed to specify multiple shaders in a single module. So we have to be more clever about the re-writing that we will be doing here.
It might be easier to ignore all of the VkCreateShaderModule calls, and intercept at the VkCreateGraphicsPipeline Calls (we can create shaders as necessary there), that way we can only override the fragment shader.
| out.MutateAndWrite(ctx, id, cmd) | ||
| } | ||
|
|
||
| func (t *ProfilePostBack) Flush(ctx context.Context, out transform.Writer) { |
There was a problem hiding this comment.
It may make sense sometime to unify all of these PostBack finalizing calls, so that we don't have to duplicate this all over the place.
| @@ -491,6 +491,14 @@ message Thumbnail { | |||
| bool disable_optimization = 7; | |||
| } | |||
|
|
|||
| message OverrideConfig { | |||
There was a problem hiding this comment.
It might be nice to make this more generic. Something more similar to having transforms be able to register them as "profiling overrides" with a name.
That way we don't have to change the public interface every time we add a what-if.
No description provided.