Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value(double) can write NaN and infinite values when lenient, as value(Number) does #1093

Merged
merged 2 commits into from
May 31, 2017
Merged

value(double) can write NaN and infinite values when lenient, as value(Number) does #1093

merged 2 commits into from
May 31, 2017

Conversation

Miha-x64
Copy link
Contributor

Fixes #1090.

Miha-x64 added 2 commits May 31, 2017 11:11
@Miha-x64
Added test which shows that lenient JsonWriter fails writing infinite…
d32371e 
… primitive doubles, but does not fail writing boxed doubles, as stated in #1090.
@Miha-x64
Fixed JsonWriter#value(double) to write infinite and NaN values when …
9963a47 
…lenient, as JsonWriter#value(Number) does. (fixes #1090)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Miha-x64
Copy link
Contributor Author

I've signed it.

@googlebot
Copy link

CLAs look good, thanks!

@inder123 inder123 self-assigned this May 31, 2017
@inder123 inder123 merged commit ada597e into google:master May 31, 2017
This was referenced Dec 11, 2017
Open
Closed
sebasjm pushed a commit to sebasjm/gson that referenced this pull request Mar 11, 2018
@Miha-x64 @inder123
value(double) can write NaN and infinite values when lenient, as valu…
d145270 
…e(Number) does (google#1093)

* Added test which shows that lenient JsonWriter fails writing infinite primitive doubles, but does not fail writing boxed doubles, as stated in google#1090.

* Fixed JsonWriter#value(double) to write infinite and NaN values when lenient, as JsonWriter#value(Number) does. (fixes google#1090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees

@inder123 inder123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Miha-x64 @googlebot @JakeWharton @inder123