Add setting for leniency on Gson instance. #771
Conversation
|
This is good. It’s a bit unfortunate that by default |
|
LGTM. @inder123 any thoughts? |
Agree! Too late to change. Just trying to make the best of that unfortunate situation. |
| } | ||
|
|
||
| public void testLenientFromJson() { | ||
| String json = gson.fromJson("\"Hello\"", String.class); |
There was a problem hiding this comment.
Wanna use another example? It’s likely we’ll support top-level primitives.
There was a problem hiding this comment.
Yep yep. I was planning on porting the RFC 7159 change to here today anyway.
There was a problem hiding this comment.
Updated to use comments and single-quote string in otherwise valid JSON.
Add a JsonReader factory (for parity with the JsonWriter one) which provides a configured instance using the Gson settings.
JakeWharton
force-pushed
the
jw/global-leniency
branch
from
c5ac860 to
3360c93
Compare
|
LGTM! |
| @@ -705,6 +714,15 @@ public JsonWriter newJsonWriter(Writer writer) throws IOException { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a new JSON writer configured for the settings on this Gson instance. | |||
| */ | |||
| public JsonReader newJsonReader(Reader reader) { | |||
There was a problem hiding this comment.
The method body seems fairly straightforward. Why can't the developer do this themselves?
We could just expose an isLenient() method instead. That will have uses beyond the low-level streaming. For example, a TypeAdapterFactory can then use Gson.isLenient() to make decisions.
There was a problem hiding this comment.
Parity with newJsonWriter and protection against future configuration options being added.
There was a problem hiding this comment.
Ok, that seems reasonable.
Add setting for leniency on Gson instance.
Add setting for leniency on Gson instance.
Add a JsonReader factory (for parity with the JsonWriter one) which provides a configured instance using the Gson settings.