-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plaintext-backend: export log for other uses #1567
plaintext-backend: export log for other uses #1567
Conversation
Get it working with manual expansion of location in rule impl - args.add_all(ctx.attr.pass_flags)
+ pass_flags_location_expanded = [ctx.expand_location(flag, ctx.attr.data) for flag in ctx.attr.pass_flags]
+ args.add_all(pass_flags_location_expanded) |
1ad9f0d
to
4eb5a38
Compare
41b7ba1
to
6e4bff7
Compare
Rebased after #1550 is in. |
a0e207f
to
8580ec9
Compare
8580ec9
to
185d654
Compare
185d654
to
d785f73
Compare
Rebased to resolve merge conflict |
I believe this PR is failing to integrate due to the use of symlinks. Though I know we had used symlinks before, for whatever reason this time it's raising an exception in copybara. I have filed a bug internally, but when I am done with the conference craziness (Monday) I can look into how to migrate this to use bazel |
The bug was fixed internally so we will probably be able to merge this as-is in a day or two. |
I can pull it in! |
Following #1550 (comment), I was able to persist the log file as a target and the openfhe test can see it. However there are some path problems. The file structure
heir-opt
would see isNote the
bazel-out/k8-dbg
. It means that if we want to import some generated file into heir-opt through thedata
label, its path is ugly.The argument for the test is
I have not find a way to turn a local label into path.