Register CC toolchain from rules_cc
#1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukawa
force-pushed
the
cc_toolchain_from_rules_cc
branch
from
1d72af8 to
de6ea52
Compare
|
Sorry, it seems that mac build starts failing with this change. Let us hold until I figure out what's going on. |
yukawa
force-pushed
the
cc_toolchain_from_rules_cc
branch
from
de6ea52 to
d610d15
Compare
This reworks my previous PR google#1156 [1], which was to make Windows bazel build compatible with --noincompatible_enable_cc_toolchain_resolution option (google#1102) (google#1112). The difference from the previous approach is that this commit uses CC toolchains defined by 'rules_cc' rather than the ones implicitly defined by the Bazel itself. Given that 'rules_cc' becomes the new home of CC-related rules and configurations, hopefully this change will reduce the likelihood of future troubles. There must be no observable behavior change in the final artifacts. [1]: 4aad25e
yukawa
force-pushed
the
cc_toolchain_from_rules_cc
branch
from
d610d15 to
b3f9cdc
Compare
|
It turns out that there is an order dependency between
Fixed in the latest commit and the CI looks to be passing. This is now ready for review again. |
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reworks my previous PR #1156 that was to make Windows bazel build compatible with
--noincompatible_enable_cc_toolchain_resolutionoption, which is now unconditionally enabled (#1102) (#1112).
The difference from the previous approach is that this commit uses CC toolchains defined by
rules_ccrather than the ones implicitly defined by the Bazel itself.Given that
rules_ccbecomes the new home of CC-related rules and configurations, hopefully this change will reduce the likelihood of future troubles.There must be no observable behavior change in the final artifacts.
Issue IDs
mozc_tip32.dllbuild with Bazel is not 32-bit binary #1102--noincompatible_enable_cc_toolchain_resolutionin Windows build #1112Steps to test new behaviors (if any)
Mozc64.msiwith BazelMozc64.msidumpbin /headers "C:\Program Files (x86)\Mozc\mozc_tip32.dll" | findstr machine14C machine (x86)is shown.