Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Extend trusted origin to support *.proxy.googlers.com hostnames #1152

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

bhamiltoncx
Copy link
Member

This builds on f2511be to extend support for trusted origins to *.proxy.googlers.com hostnames, which are used in addition to *.c.googlers.com hostnames.

I extended the unit tests to cover this and confirmed the tests pass with ./ui/run-unittests.

Bug: http://b/402495918

This builds on f2511be to extend
support for trusted origins to `*.proxy.googlers.com` hostnames,
which are used in addition to `*.c.googlers.com` hostnames.

I extended the unit tests to cover this and confirmed the
tests pass with `./ui/run-unittests`.

Bug: http://b/402495918
@bhamiltoncx bhamiltoncx requested a review from a team as a code owner April 2, 2025 20:27
@bhamiltoncx bhamiltoncx requested a review from stevegolton April 2, 2025 20:27
@LalitMaganti LalitMaganti requested a review from primiano April 2, 2025 20:28
@LalitMaganti
Copy link
Collaborator

@primiano can you please take a call on this? Should we be doing this at all?

@bhamiltoncx
Copy link
Member Author

@primiano can you please take a call on this? Should we be doing this at all?

For more context, currently we can't test any Google code which opens a tab to ui.perfetto.dev and posts the Perfetto protobuf over to the other tab. The origin has changed to *.proxy.googlers.com, so it doesn't pass this check.

Without this, ui.perfetto.dev loads but it ignores the message from the other tab.

I'm not 100% sure what the trusted origin logic was originally about, but it's been around for a long time.

@LalitMaganti
Copy link
Collaborator

I'm not 100% sure what the trusted origin logic was originally about, but it's been around for a long time.

I know but it was a convenience hack which we probably shouldn't have done in the first place honestly.

@bhamiltoncx
Copy link
Member Author

I know but it was a convenience hack which we probably shouldn't have done in the first place honestly.

Makes sense. Hopefully there's an alternative for testing code which opens a Perfetto tab. If not, a lot of code will go untested.

@LalitMaganti LalitMaganti merged commit 745c6d3 into google:main Apr 7, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants