-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend proto-lens API to support serializing the protobuf JSON format #455
base: master
Are you sure you want to change the base?
Conversation
…puile without a hard protobuf compiler dependency
Thanks for the change @iand675. You are right that the bootstrap story is a complicated one. We pondered it quite a bit before landing on this one. The reasoning was that people who want to work with protobuf wouldn't consider it a chore to have I'm also semi-blocked on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not pass the required checks.
I needed to support JSON deserialization to the Protobuf models to integrate with a third party system with a large number of protocol buffer definitions, so it was infeasible to hand-write them.
This PR adds support for the serialization formats outlined here: https://protobuf.dev/programming-guides/proto3/#json
I also bumped some dependencies and replaced the
Setup.hs
codegen approach for the official protobuf types because the Setup.hs approach absolutely refused to work in the upstream Nix project. I could probably roll it back, but it's nice IMO to be able to use some of the base packages to the ecosystem without having to have the protocol buffer compiler installed.