Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set rpath #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't set rpath #105

wants to merge 1 commit into from

Conversation

jbicha
Copy link

@jbicha jbicha commented Dec 7, 2017

See google/brotli#629 where this same change is proposed for brotli.

Debian doesn't like rpath. I believe Fedora has similar concerns.

CC @fred-wang since he added this in ed27db0

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants