-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gengapic): add snippets #1220
Conversation
eb7a80e
to
f266e8e
Compare
Here is the summary of possible violations 😱 There are 2 possible violations for not having product prefix.
There are format violations for 2 region tags.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool, @quartzmo well done.
Can you add a new config file for SnippetBot to stop it from bothering us about region tags in generator code? Add the following to # The generator prints region tags and snippet-bot wants to correct
# the printing code.
ignoreFiles:
- "internal/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused why changes that have already landed in main
are showing up in the diffs here, is anyone else seeing that? Like ci.yaml
and deps.yaml
changing to bazel verison 6.0.0. And the CHANGELOG.md including the latest release...why are they in this PR?
@noahdietz I also see those diffs in the file view for this PR in GH. But I do not see them locally. The following returns no differences: git diff main -- .github/workflows/ci.yaml I guess maybe GH might be confused by so many commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on doing the conditional refactor now, it made things a lot cleaner.
The snippet output added in this change is known to differ from legacy snippetgen output as follows:
resultType
pointer values contain the*
prefix. (In current metadata, the*
does not appear.)https
replaces current headers' usage ofhttp
.protoc
plugin.iam
imports is now removed. Note that this decreases thesegments.end
value by1
in the new snippet metadata.datacatalog "cloud.google.com/go/datacatalog/apiv1beta1" - iampb "google.golang.org/genproto/googleapis/iam/v1"
clientMethod.method
values are changed to the actual protobuf source values for mixin methods: