Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gha): remove workaround for Bazel crash on macOS #12931

Merged

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Oct 19, 2023

Now that the build uses Bazel v6.4.0, which includes the fix for bazelbuild/bazel#18965, we can remove the retry from #12127.


This change is Reviewable

Now that the build uses Bazel v6.4.0, which includes the fix
for bazelbuild/bazel#18965, we can
remove the retry.
@devbww devbww temporarily deployed to internal October 19, 2023 20:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98dcfc5) 93.62% compared to head (00c421a) 93.62%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12931      +/-   ##
==========================================
- Coverage   93.62%   93.62%   -0.01%     
==========================================
  Files        2067     2067              
  Lines      180213   180213              
==========================================
- Hits       168719   168717       -2     
- Misses      11494    11496       +2     
Files Coverage Δ
generator/internal/descriptor_utils.cc 84.15% <100.00%> (ø)
generator/internal/format_class_comments.cc 100.00% <100.00%> (ø)
generator/internal/format_class_comments_test.cc 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devbww devbww marked this pull request as ready for review October 19, 2023 20:49
@devbww devbww requested a review from a team as a code owner October 19, 2023 20:49
@devbww devbww merged commit 3c1a946 into googleapis:main Oct 20, 2023
@devbww devbww deleted the ci-gha-workaround-Bazel-on-macOS-crash branch October 20, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants