Review Changes

googleapis · Feb 3, 2018 · bd67ea7 · bd67ea7
1 parent ffc01ce
commit bd67ea7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/firestore/google/cloud/firestore_v1beta1/client.py b/firestore/google/cloud/firestore_v1beta1/client.py
@@ -251,7 +251,7 @@ def write_option(**kwargs):
         :meth:`~.DocumentReference.update` and
         :meth:`~.DocumentReference.delete`.
 
-        One of the following two keyword arguments must be provided:
+        One of the following keyword arguments must be provided:
 
         * ``last_update_time`` (:class:`google.protobuf.timestamp_pb2.\
            Timestamp`): A timestamp. When set, the target document must exist

diff --git a/firestore/tests/system.py b/firestore/tests/system.py
@@ -207,7 +207,6 @@ def test_update_document(client, cleanup):
     assert document_id in exc_info.value.message
 
     # 1. Try to update before the document exists (now with an option).
-
     option1 = client.write_option(exists=True)
     with pytest.raises(NotFound) as exc_info:
         document.update({'still': 'not-there'}, option=option1)

diff --git a/firestore/tests/unit/test__helpers.py b/firestore/tests/unit/test__helpers.py
@@ -1218,7 +1218,7 @@ def _helper(self, option=None, do_transform=False, **write_kwargs):
             'yum': _value_pb(bytes_value=value),
         })
         if isinstance(option, ExistsOption):
-            write_kwargs = {'current_document' : {'exists': option._exists}}
+            write_kwargs.update({'current_document' : {'exists': option._exists}})
 
         expected_update_pb = write_pb2.Write(
             update=document_pb2.Document(