feat!: [google-cloud-modelarmor] Make enable_floor_setting_enforcement field optional #13557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
fix: fix typo in csam_filter_filter_result in SanitizationResult output feat: Add SDP info types in SdpDeidentify results docs: A comment for field `inspect_template` in message `.google.cloud.modelarmor.v1.SdpAdvancedConfig` is changed docs: A comment for field `deidentify_template` in message `.google.cloud.modelarmor.v1.SdpAdvancedConfig` is changed PiperOrigin-RevId: 730701858 Source-Link: googleapis/googleapis@478799c Source-Link: googleapis/googleapis-gen@4cd1420 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6IjRjZDE0MjAwYzY4ZWY1MWVlMmIyZGQ5ODRkNTZhMWY5MjZmNWNmODUifQ==
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
the
do not merge
|
Wait for discussion in b/397833450 |
parthea
added
the
status: blocked
|
I'm going to mark this PR as draft to avoid accidentally merging these changes. I'll mark it ready for review once b/397833450 is updated. |
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
PiperOrigin-RevId: 732994462 Source-Link: googleapis/googleapis@50cbb15 Source-Link: googleapis/googleapis-gen@6ca4b87 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6IjZjYTRiODczMGM0ZTVjYzdkM2U1NDA0OWNiZDZmOTlkOGQ3Y2IzM2MifQ==
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Wait for cl/733251391 |
…output PiperOrigin-RevId: 733563492 Source-Link: googleapis/googleapis@c3e445f Source-Link: googleapis/googleapis-gen@8590eaa Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6Ijg1OTBlYWE5MWIxZWQ2ZTVkMzM3OTcyYjFlODBkNzJiNzQzZDU3NzUifQ==
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
changed the title
parthea
changed the title
parthea
removed
do not merge
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
|
This is now unblocked (Googlers see cl/733563492 which reverted the change that was blocking this PR) |
parthea
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Breaking change exemption filed: b/400651671 |
ohmayr
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: Revert typo in csam_filter_filter_result in SanitizationResult output
feat: Add SDP info types in SdpDeidentify results
docs: A comment for field
inspect_templatein message.google.cloud.modelarmor.v1.SdpAdvancedConfigis changeddocs: A comment for field
deidentify_templatein message.google.cloud.modelarmor.v1.SdpAdvancedConfigis changedfeat!: [google-cloud-modelarmor] Make enable_floor_setting_enforcement field optional
chore: Update gapic-generator-python to v1.23.3
chore: Revert typo in csam_filter_filter_result in SanitizationResult output
END_COMMIT_OVERRIDE
PiperOrigin-RevId: 733563492
Source-Link: googleapis/googleapis@c3e445f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/8590eaa91b1ed6e5d337972b1e80d72b743d5775
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6Ijg1OTBlYWE5MWIxZWQ2ZTVkMzM3OTcyYjFlODBkNzJiNzQzZDU3NzUifQ==
BEGIN_NESTED_COMMIT
chore: [google-cloud-modelarmor] Update gapic-generator-python to v1.23.3
PiperOrigin-RevId: 732994462
Source-Link: googleapis/googleapis@50cbb15
Source-Link: https://github.com/googleapis/googleapis-gen/commit/6ca4b8730c4e5cc7d3e54049cbd6f99d8d7cb33c
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6IjZjYTRiODczMGM0ZTVjYzdkM2U1NDA0OWNiZDZmOTlkOGQ3Y2IzM2MifQ==
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SDP info types in SdpDeidentify results
docs: A comment for field
inspect_templatein message.google.cloud.modelarmor.v1.SdpAdvancedConfigis changeddocs: A comment for field
deidentify_templatein message.google.cloud.modelarmor.v1.SdpAdvancedConfigis changedPiperOrigin-RevId: 730701858
Source-Link: googleapis/googleapis@478799c
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4cd14200c68ef51ee2b2dd984d56a1f926f5cf85
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6IjRjZDE0MjAwYzY4ZWY1MWVlMmIyZGQ5ODRkNTZhMWY5MjZmNWNmODUifQ==
END_NESTED_COMMIT