-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow protobuf 6.x #13637
base: main
Are you sure you want to change the base?
fix: Allow protobuf 6.x #13637
Conversation
presubmit
This was fixed by 346097d |
""" | ||
Run all tests with pre-release versions of dependencies installed | ||
rather than the standard non pre-release versions. | ||
Pre-releases versions can be installed using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-releases versions can be installed using | |
Pre-release versions can be installed using |
""" | ||
|
||
# Install all dependencies | ||
session.install(".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want a -e
here like in the previous test?
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES | ||
# Install dependencies for the unit test environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency with the other test:
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES | |
# Install dependencies for the unit test environment | |
# Install dependencies for the unit test environment | |
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES |
system_deps_all = ( | ||
SYSTEM_TEST_STANDARD_DEPENDENCIES | ||
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES | ||
+ SYSTEM_TEST_EXTRAS | ||
) | ||
# Install dependencies for the system test environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency with the other test:
system_deps_all = ( | |
SYSTEM_TEST_STANDARD_DEPENDENCIES | |
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES | |
+ SYSTEM_TEST_EXTRAS | |
) | |
# Install dependencies for the system test environment | |
# Install dependencies for the system test environment | |
system_deps_all = ( | |
SYSTEM_TEST_STANDARD_DEPENDENCIES | |
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES | |
+ SYSTEM_TEST_EXTRAS | |
) |
|
||
# Because we test minimum dependency versions on the minimum Python | ||
# version, the first version we test with in the unit tests sessions has a | ||
# constraints file containing all dependencies and extras that should be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency with previous
# constraints file containing all dependencies and extras that should be installed. | |
# constraints file containing all dependencies and extras. |
"protobuf_implementation", | ||
["python", "upb"], | ||
) | ||
def core_deps_from_source(session, protobuf_implementation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make it clear it's the local source, as opposed to checking it out from somewhere?
def core_deps_from_source(session, protobuf_implementation): | |
def core_deps_from_local_source(session, protobuf_implementation): |
# Install dependencies specified in `testing/constraints-X.txt`. | ||
session.install(*constraints_deps) | ||
|
||
core_dependencies_from_source = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is shorter than the corresponding prerel_deps
in the previous test. Can we make that one shorter as well? Or does this list include transitive dependencies that are not included in the other? We should explain why they don't correspond.
Apply changes from googleapis/gapic-generator-python#2352 and googleapis/gapic-generator-python#2347 to 4 packages containing protobuf stubs which are not automatically generated using
gapic-generator-python
fix: resolve issue where pre-release versions of dependencies are installed