Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Firestore: pick up fixes in GAPIC generator. #6497

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Firestore: pick up fixes in GAPIC generator. #6497

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/firestore/artman_firestore.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/firestore-v1beta1.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: firestore Issues related to the Firestore API. codegen kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 14, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated firestore to pick up changes in the API or client library generator. [DO NOT MERGE] Firestore: pick up fixes in GAPIC generator. Nov 14, 2018
tseaver
tseaver suggested changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes fixes from these PRs:

But CI is broken. :(

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@tseaver tseaver mentioned this pull request Nov 14, 2018
Merged
@tseaver
Copy link
Contributor

tseaver commented Nov 14, 2018

Superseded by #6523.

tseaver added a commit that referenced this pull request Nov 15, 2018
@tseaver
Firestore: pick up fixes to GAPIC generator. (#6523)
a0bd8d0 
* Firestore: pick up fixes to GAPIC generator.

Closes #6497.

Includes changes to generated tests.

Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396

* Fix overlong lines introduced in PR #6481.
@tseaver tseaver deleted the autosynth-firestore branch November 15, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @googlebot @kokoro-team