-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to output candidate releases #1041
base: main
Are you sure you want to change the base?
Conversation
Hi @chingor13! I know you must be busy. Any chance you could have a look at this? I'm open to feedback if you want any changes. 🙇 |
Hi @niieani , I would be interested to also have a Something like: export async function main() {
...
if (inputs.only === 'list-pull-requests') {
core.debug('Listing pending pull requests');
outputCandidatePRs(await manifest.buildPullRequests());
}
...
}
...
function outputCandidatePRs(prs: ReleasePullRequest[]) {
prs = prs.filter(pr => pr !== undefined);
core.setOutput('prs_pending', prs.length > 0);
if (prs.length) {
core.setOutput('pr', prs[0]);
core.setOutput('prs', JSON.stringify(prs));
}
} So in this case the pr and prs output would be of type ReleasePullRequest object instead of PullRequest object. What do you think about it? |
Hi @le-yams ! I think that's a good addition, however note that I've been trying to get this merged since October 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
I think I'd prefer a dry-run
boolean option to mirror what the CLI does rather than maintaining a list of actions.
Thank you for taking a look @chingor13. |
adds ability to output candidate releases, and candidate PRs without actually releasing or updating PRs
For the purposes of releasing, it is useful to just get the information of the packages that are about to be released.
If
only: 'list-candidate-releases'
is set, only output information about which packages would be released.It provides
releases_pending
andpaths_to_release
as the outputs.In order to enable this new feature, I've added a new input called
only
that allows running only the desired functionality ('create-github-releases' | 'list-candidate-releases' | 'update-pull-requests'
).It is not a breaking change, and is backwards compatible with the
skipGitHubRelease
andskipGitHubPullRequest
inputs.