-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add possibility to catch errors with bot.catch
on webhook
#741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are a breath of fresh air, you made an excellent observation about our ability to drop the whole FATAL error thing. Thank you!
I just have a tiny request about the assertion in the test:
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
this should work:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
This PR adds error handling with bot.catch for webhooks.
I have several questions:
FATAL
console.logCloses #702