docs: auth blog post #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request adds a new blog post about Kubernetes authentication and authorization, along with the necessary infrastructure to support a blog section in the documentation. The changes include updates to the project's TODO list, modifications to the documentation structure, and the addition of new files for the blog functionality. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @grampelberg - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| const Blog = () => { | ||
| const { asPath } = useRouter() | ||
|
|
||
| let linkClasses = [ |
There was a problem hiding this comment.
suggestion: Consider extracting class list
The list of classes is quite long. Consider extracting this into a separate constant or utility function to improve readability and maintainability of the component.
const LINK_CLASSES = [
'border',
'border-zinc-200',
// ... other classes
]
const Blog = () => {
const { asPath } = useRouter()
const linkClasses = LINK_CLASSES
| - Move YAML over to viewport. Should viewport be doing syntax highlighting by | ||
| default? How do we do a viewport over a set of lines that require history to | ||
| do highlighting? | ||
|
|
||
| - There's a bug somewhere in `log_stream`. My k3d cluster restarted and while I | ||
| could get all the logs, the stream wouldn't keep running - it'd terminate | ||
| immediately. `stern` seemed to be working fine. Recreating the cluster caused | ||
| immediately. `stern` seemed to be working fine. Recreating the cluster causedx |
There was a problem hiding this comment.
issue (documentation): Fix typo: 'causedx' should be 'caused'
grampelberg
force-pushed
the
thomas--auth-blog
branch
from
1d993df to
cdeddf1
Compare
grampelberg
force-pushed
the
thomas--auth-blog
branch
from
cdeddf1 to
51d6663
Compare
grampelberg
force-pushed
the
thomas--auth-blog
branch
from
51d6663 to
c68ba15
Compare
grampelberg
force-pushed
the
thomas--auth-blog
branch
from
c68ba15 to
4e596d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add a new blog section to the documentation, including a post on simplifying Kubernetes authentication with OpenID Connect. Enhance the Tailwind CSS configuration to center content across the site.
New Features:
Enhancements:
Documentation: