NET-260 REST API tests #2351
NET-260 REST API tests #2351
Conversation
- added `/api/enrollment_keys` for non-admins - unit test for enrollment keys for non-admins
# Conflicts: # controllers/server.go
TobiaszCudnik
requested review from
Aceix,
theguy951357,
gabrielseibel1,
afeiszli,
abhishek9686 and
mattkasun
- return hosts with partial access
…st-api-tests # Conflicts: # controllers/enrollmentkeys.go
database/sqlite.go
Outdated
| @@ -3,14 +3,23 @@ package database | |||
| import ( | |||
| "database/sql" | |||
| "errors" | |||
| _ "github.com/mattn/go-sqlite3" // need to blank import this package | |||
There was a problem hiding this comment.
did you run go fmt and/or go import. stdlib imports should be listed first followed by external lib imports
There was a problem hiding this comment.
Fixed.
goimports should be added to precommit. gofmt orders it differently.
- goimports
@theguy951357 It's not a user facing feature / release-bound code, so it doesnt have to be QA-ed. Thanks anyway! |
TobiaszCudnik
changed the base branch from
NET-152/enrollment-keys-for-non-admins
to
develop
| } | ||
| err = logic.CreateUser(user) | ||
| if err != nil { | ||
| t.Error("Error creating a user ", err) |
There was a problem hiding this comment.
could use t.Fatal here?
| adminConfigBad.MasterKey = "wrongpass" | ||
| adminConfigBad.Password = "wrongpass" | ||
| // add configs | ||
| config.SetContext("user-ctx-1", userConfig) |
There was a problem hiding this comment.
the context names could be extracted as variables/consts maybe, to avoid writing it wrong and facing a difficult to debug situation
| keys := *functions.GetEnrollmentKeys() | ||
| assert.Len(t, keys, 1, "1 key expected") | ||
| assert.Len(t, keys[0].Networks, 1, "Key with 1 network expected") | ||
| assert.Equal(t, keys[0].Networks[0], n1.NetID, "Network ID matches") |
There was a problem hiding this comment.
are these messages not displayed on failure? honestly thought that but am not sure
| // TODO doesnt return err | ||
| res := *functions.GetEnrollmentKeys() | ||
| fmt.Println(res) | ||
| //assert.Error(t, res, "403 error") |
There was a problem hiding this comment.
should probably have an assertion here, len 0?
Describe your changes
NET-260 REST API tests for
GET /api/v1/enrollment-keys.Provide testing steps
go test ./... -v -tags integration -test.run TestHasNetworksAccessAPIChecklist before requesting a review