Nvt detailspage test #2660
Nvt detailspage test #2660
Conversation
…tailspage-test
Codecov Report
@@ Coverage Diff @@
## master #2660 +/- ##
==========================================
+ Coverage 60.77% 61.06% +0.28%
==========================================
Files 1113 1113
Lines 28081 28081
Branches 7993 8025 +32
==========================================
+ Hits 17067 17148 +81
+ Misses 9965 9894 -71
+ Partials 1049 1039 -10
Continue to review full report at Codecov.
|
|
Finally ... |
…tailspage-test
gsa/src/web/entity/__tests__/box.js
Outdated
|
|
||
| import EntityBox from '../box'; | ||
|
|
||
| setLocale('en'); | ||
|
|
||
| const date = Date('2019-01-01T12:00:00Z'); | ||
| const date2 = Date('2019-02-02T12:00:00Z'); | ||
| const manualUrl = 'test/'; |
There was a problem hiding this comment.
Do we really need the manualUrl here? I can't figure out where that would be used.
There was a problem hiding this comment.
It's used in the help icon to direct to the manual. Normally it's set in GOS, but here we probably need it for testing to be test...
There was a problem hiding this comment.
I'm sorry, I should have phrased my question better. This is the test for the entity box. Where do we use a help icon here? I can't find any manual links here and I don't think we need the manualUrl for anything else.
And as a note: for tests with a help icon (or rather with a manual link) the manualUrl needs to be set but it doesn't have to be 'test/' it just needs to be defined.
Co-authored-by: sarahd93 <sarah.diedrich93@gmail.com>
Co-authored-by: sarahd93 <sarah.diedrich93@gmail.com>
Co-authored-by: sarahd93 <sarah.diedrich93@gmail.com>
What:
While there:
Why:
How:
Checklist: