Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement policy component mutations #2684

Merged
merged 10 commits into from
Feb 1, 2021
Merged

Implement policy component mutations #2684

merged 10 commits into from
Feb 1, 2021

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jan 27, 2021 •
edited
Loading

What:

Why:

How:

Manual and auto testing.

Checklist:

@codecov
Copy link

codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #2684 (9392565) into master (0955977) will increase coverage by 0.03%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2684      +/-   ##
==========================================
+ Coverage   60.73%   60.77%   +0.03%     
==========================================
  Files        1113     1113              
  Lines       28052    28081      +29     
  Branches     7991     7993       +2     
==========================================
+ Hits        17037    17065      +28     
  Misses       9967     9967              
- Partials     1048     1049       +1
Impacted Files Coverage Δ
gsa/src/web/pages/policies/component.js 44.53% <50.00%> (+0.52%) ⬆️
gsa/src/web/graphql/policies.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0955977...9392565. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review January 27, 2021 15:33
@saberlynx saberlynx requested review from a team, bjoernricks and sarahd93 January 27, 2021 15:33
bjoernricks
bjoernricks requested changes Jan 29, 2021
View reviewed changes
@saberlynx saberlynx requested a review from bjoernricks January 29, 2021 15:32
@bjoernricks bjoernricks self-requested a review February 1, 2021 09:24
@bjoernricks bjoernricks merged commit fd8dad7 into greenbone:master Feb 1, 2021
@saberlynx saberlynx deleted the policy-component branch February 1, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@sarahd93 sarahd93 Awaiting requested review from sarahd93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks