Refactor Audit Component into Function #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberlynx
commented
Jan 29, 2021
|
|
||
| this.handleInteraction = this.handleInteraction.bind(this); | ||
| let defaultScannerId = OPENVAS_DEFAULT_SCANNER_ID; |
There was a problem hiding this comment.
Gives defaultScannerId a default value.
saberlynx
commented
Jan 29, 2021
| const reportExportFileName = userDefaultsSelector.getValueByName( | ||
| 'reportexportfilename', | ||
| ); | ||
| let reportFormats = []; |
There was a problem hiding this comment.
Give reportFormats a default value.
Codecov Report
@@ Coverage Diff @@
## master #2695 +/- ##
==========================================
+ Coverage 60.66% 60.72% +0.05%
==========================================
Files 1113 1113
Lines 28066 28063 -3
Branches 8024 7991 -33
==========================================
+ Hits 17025 17040 +15
+ Misses 9993 9975 -18
Partials 1048 1048
Continue to review full report at Codecov.
|
sarahd93
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Refactors component into function. I have decided to not use graphQL queries in lieu of loaders and selectors, at this stage because adding passive queries would necessitate changing listpage and detailspage tests to add mocks and I would like to keep them the same for now.
Why:
How:
Manually tested. Everything still works as normal.
Checklist: