-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEA-265 Improvement of configure task #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix hint
case is_list(String) of | ||
true -> | ||
Trimmed = string:trim(String), | ||
unicode:characters_to_binary(Trimmed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a note, but is not needed.
This does not protect from "
that if left unescaped will lead to crashes in the config file.
And if the token is between ""
will also crash -> <<""mytoken"">>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest change:
unicode:characters_to_binary(Trimmed); | |
Whitespace = unicode_util:whitespace(), | |
Trimmed = string:trim(String, both, Whitespace ++ [$"]), |
should fix this issue by removing the whitespaces and unescaped "
It looks great! As soon as this is merged, I'll update the wiki tutorial and grisp_manager so everything looks the same :) The only thing that's a bit strange to me is having the defaults in quotes. |
Summary
This PR is linked to the PR SEA-265 Improvement of configure task on
rebar3_grisp
In this PR a few improvements have been done for the
configure
task:How to test ?
To test this PR you will need a local setup. Indeed, since the changes aren't pushed on the main branch the version of the plugin globally installed on your computer won't reflect the changes made for this PR. Thus we will need to use a throw off grisp project and use the _checkouts folder to use the correct versions of this repo as well as the rebar3_grisp repo. Both of them should be setup to checkout the branch named SEA-365-grisp-conf-upgrade
Example of the overall look of the task