adds QueryableOptions.assertNoFailure to treat errors as fatalError #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groue
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thank you very much @ChristophKaser, this is a very sensible pull request 👍
We also need to add:
/// - ``assertNoFailure``above async in the "Predefined options" section of the QueryableOptions documentation at the top of the file.
And I suggest one documentation change below, if you are ok.
Sources/GRDBQuery/Queryable+DatabaseContext/QueryableOptions.swift
Outdated
Show resolved
Hide resolved
Don't reference implementation internals in the documentation Co-authored-by: Gwendal Roué <gr@pierlis.com>
|
Thank you for your review! I have committed your change to the documentation and added assertNoFailure to the predefined options section. |
|
I'll ship a new version shortly. |
|
Great, thank you! :) |
|
Hi @ChristophKaser. Version 0.11.0 is out, with your pull request baked in. Thank you very much! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to set queryableOptions to QueryableOptions.assertNoFailure to treat errors as fatal.
See #63 (comment)