Develop - Know the Terrain #3777
Conversation
|
Needs testing to see what happens if all attackers becomes ineligible after this event is played but before the conflict officially starts |
marcsoiferman-cm
changed the title
| context.player.isDefendingPlayer() && | ||
| event.conflict.conflictProvince.location !== Locations.StrongholdProvince | ||
| }, | ||
| target: { |
There was a problem hiding this comment.
if the card doesn't target, you need to use a selectCard action (or promptForSelect if you're using a handler)
server/game/player.js
Outdated
| @@ -1177,6 +1177,45 @@ class Player extends GameObject { | |||
| return this.anyEffect(EffectNames.EventsCannotBeCancelled); | |||
| } | |||
|
|
|||
| switchProvinces(province1, province2) { | |||
There was a problem hiding this comment.
This should be dealt with by moveCard
server/game/player.js
Outdated
| cardsInLocation2.push(province1); | ||
| } | ||
|
|
||
| getProvinceArray(location) { |
There was a problem hiding this comment.
This should be dealt with by getSourceList
| ringFate: ring.fate | ||
| })]; | ||
|
|
||
| this.game.openEventWindow(events); |
There was a problem hiding this comment.
This isn't really the right way to do this - we need to make conflict declaration a proper event which can be interrupted and reacted to. We need to know where covert fits in to do it correctly though
marcsoiferman-cm
changed the title
marcsoiferman-cm
changed the title
… now: 1) Reactions to fate being taken (including a new event for Enlightened Warrior) 2) Province is revealed, if facedown, (interrupt window for Know the Terrain) 3) Reaction to conflict declaration Had to update Enlightened Warrior as a result (he reacted to conflict declaration, rather than a ring with fate being chosen)
|
Not sure how important this ruling actually is. The event works as expected now, based on the RAW. Updates for this required splitting taking ring fate and revealing the province, so the chat messages are re-arranged, I think. |
|
Closing in preparation of migration. Can be re-opened against new repository after migration if necessary. |
Closes #3760
Needs a ruling about when exactly in the conflict declaration the interrupt window for this opens.