Skip to content

Commit

Permalink
Pin vc14_runtime for nightly fix (facebookresearch#4234)
Browse files Browse the repository at this point in the history
Summary:

Seems like an update to vc14_runtime has caused nightlies to fail: https://github.com/facebookresearch/faiss/actions/runs/13714957634/job/38362967507

Pinning it to the most recently successful nightly's version: https://github.com/facebookresearch/faiss/actions/runs/13612759807/job/38054300489

Differential Revision: D70904925
  • Loading branch information
gtwang01 authored and facebook-github-bot committed Mar 10, 2025
1 parent 653be59 commit 000b9b5
Show file tree
Hide file tree
Showing 2 changed files with 150 additions and 129 deletions.
273 changes: 144 additions & 129 deletions .github/workflows/build-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,140 +30,155 @@ jobs:
git --no-pager diff --color
exit 1
fi
linux-x86_64-cmake:
name: Linux x86_64 (cmake)
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
linux-x86_64-AVX2-cmake:
name: Linux x86_64 AVX2 (cmake)
needs: linux-x86_64-cmake
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
opt_level: avx2
linux-x86_64-AVX512-cmake:
name: Linux x86_64 AVX512 (cmake)
needs: linux-x86_64-cmake
runs-on: faiss-aws-m7i.large
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
opt_level: avx512
linux-x86_64-AVX512_SPR-cmake:
name: Linux x86_64 AVX512_SPR (cmake)
needs: linux-x86_64-cmake
runs-on: faiss-aws-m7i.large
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
opt_level: avx512_spr
linux-x86_64-GPU-cmake:
name: Linux x86_64 GPU (cmake)
needs: linux-x86_64-cmake
runs-on: 4-core-ubuntu-gpu-t4
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
gpu: ON
linux-x86_64-GPU-w-CUVS-cmake:
name: Linux x86_64 GPU w/ cuVS (cmake)
needs: linux-x86_64-cmake
runs-on: 4-core-ubuntu-gpu-t4
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
gpu: ON
cuvs: ON
linux-x86_64-GPU-w-ROCm-cmake:
name: Linux x86_64 GPU w/ ROCm (cmake)
needs: linux-x86_64-cmake
runs-on: faiss-amd-MI200
container:
image: ubuntu:22.04
options: --device=/dev/kfd --device=/dev/dri --ipc=host --shm-size 16G --group-add video --cap-add=SYS_PTRACE --cap-add=SYS_ADMIN
steps:
- name: Container setup
run: |
if [ -f /.dockerenv ]; then
apt-get update && apt-get install -y sudo && apt-get install -y git
git config --global --add safe.directory '*'
else
echo 'Skipping. Current job is not running inside a container.'
fi
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
gpu: ON
rocm: ON
linux-arm64-SVE-cmake:
name: Linux arm64 SVE (cmake)
needs: linux-x86_64-cmake
runs-on: faiss-aws-r8g.large
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Build and Test (cmake)
uses: ./.github/actions/build_cmake
with:
opt_level: sve
env:
# Context: https://github.com/facebookresearch/faiss/wiki/Troubleshooting#surprising-faiss-openmp-and-openblas-interaction
OPENBLAS_NUM_THREADS: '1'
linux-x86_64-conda:
name: Linux x86_64 (conda)
needs: linux-x86_64-cmake
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-tags: true
- name: Build and Package (conda)
uses: ./.github/actions/build_conda
windows-x86_64-conda:
name: Windows x86_64 (conda)
needs: linux-x86_64-cmake
# linux-x86_64-cmake:
# name: Linux x86_64 (cmake)
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# linux-x86_64-AVX2-cmake:
# name: Linux x86_64 AVX2 (cmake)
# needs: linux-x86_64-cmake
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# opt_level: avx2
# linux-x86_64-AVX512-cmake:
# name: Linux x86_64 AVX512 (cmake)
# needs: linux-x86_64-cmake
# runs-on: faiss-aws-m7i.large
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# opt_level: avx512
# linux-x86_64-AVX512_SPR-cmake:
# name: Linux x86_64 AVX512_SPR (cmake)
# needs: linux-x86_64-cmake
# runs-on: faiss-aws-m7i.large
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# opt_level: avx512_spr
# linux-x86_64-GPU-cmake:
# name: Linux x86_64 GPU (cmake)
# needs: linux-x86_64-cmake
# runs-on: 4-core-ubuntu-gpu-t4
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# gpu: ON
# linux-x86_64-GPU-w-CUVS-cmake:
# name: Linux x86_64 GPU w/ cuVS (cmake)
# needs: linux-x86_64-cmake
# runs-on: 4-core-ubuntu-gpu-t4
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# gpu: ON
# cuvs: ON
# linux-x86_64-GPU-w-ROCm-cmake:
# name: Linux x86_64 GPU w/ ROCm (cmake)
# needs: linux-x86_64-cmake
# runs-on: faiss-amd-MI200
# container:
# image: ubuntu:22.04
# options: --device=/dev/kfd --device=/dev/dri --ipc=host --shm-size 16G --group-add video --cap-add=SYS_PTRACE --cap-add=SYS_ADMIN
# steps:
# - name: Container setup
# run: |
# if [ -f /.dockerenv ]; then
# apt-get update && apt-get install -y sudo && apt-get install -y git
# git config --global --add safe.directory '*'
# else
# echo 'Skipping. Current job is not running inside a container.'
# fi
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# gpu: ON
# rocm: ON
# linux-arm64-SVE-cmake:
# name: Linux arm64 SVE (cmake)
# needs: linux-x86_64-cmake
# runs-on: faiss-aws-r8g.large
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Build and Test (cmake)
# uses: ./.github/actions/build_cmake
# with:
# opt_level: sve
# env:
# # Context: https://github.com/facebookresearch/faiss/wiki/Troubleshooting#surprising-faiss-openmp-and-openblas-interaction
# OPENBLAS_NUM_THREADS: '1'
# linux-x86_64-conda:
# name: Linux x86_64 (conda)
# needs: linux-x86_64-cmake
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# with:
# fetch-depth: 0
# fetch-tags: true
# - name: Build and Package (conda)
# uses: ./.github/actions/build_conda
# windows-x86_64-conda:
# name: Windows x86_64 (conda)
# needs: linux-x86_64-cmake
# runs-on: windows-2019
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# with:
# fetch-depth: 0
# fetch-tags: true
# - name: Build and Package (conda)
# uses: ./.github/actions/build_conda
# linux-arm64-conda:
# name: Linux arm64 (conda)
# needs: linux-x86_64-cmake
# runs-on: 2-core-ubuntu-arm
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# with:
# fetch-depth: 0
# fetch-tags: true
# - name: Build and Package (conda)
# uses: ./.github/actions/build_conda
windows-x86_64-nightly:
name: Windows x86_64 nightlies
runs-on: windows-2019
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-tags: true
- name: Build and Package (conda)
uses: ./.github/actions/build_conda
linux-arm64-conda:
name: Linux arm64 (conda)
needs: linux-x86_64-cmake
runs-on: 2-core-ubuntu-arm
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: ./.github/actions/build_conda
env:
ANACONDA_API_TOKEN: ${{ secrets.ANACONDA_API_TOKEN }}
with:
fetch-depth: 0
fetch-tags: true
- name: Build and Package (conda)
uses: ./.github/actions/build_conda
label: nightly
# @nocommit
6 changes: 6 additions & 0 deletions conda/faiss/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ outputs:
- mkl-devel >=2023.2.0 # [x86_64 and not win]
- mkl-devel =2023.1.0 # [x86_64 and win]
- python_abi =3.12
- vc14_runtime =14.42.34433 # [win]
{% endif %}
host:
- python {{ python }}
Expand All @@ -60,6 +61,7 @@ outputs:
- mkl >=2023.2.0 # [x86_64 and not win]
- mkl =2023.1.0 # [x86_64 and win]
- python_abi =3.12
- vc14_runtime =14.42.34433 # [win]
{% endif %}
- openblas =0.3.29 # [not x86_64]
run:
Expand All @@ -71,6 +73,7 @@ outputs:
- mkl >=2023.2.0 # [x86_64 and not win]
- mkl =2023.1.0 # [x86_64 and win]
- python_abi =3.12
- vc14_runtime =14.42.34433 # [win]
{% endif %}
- openblas =0.3.29 # [not x86_64]
test:
Expand Down Expand Up @@ -106,6 +109,7 @@ outputs:
- mkl >=2023.2.0 # [x86_64 and not win]
- mkl =2023.1.0 # [x86_64 and win]
- python_abi =3.12
- vc14_runtime =14.42.34433 # [win]
{% endif %}
host:
- python {{ python }}
Expand All @@ -119,6 +123,7 @@ outputs:
- mkl >=2023.2.0 # [x86_64 and not win]
- mkl =2023.1.0 # [x86_64 and win]
- python_abi =3.12
- vc14_runtime =14.42.34433 # [win]
{% endif %}
run:
- python {{ python }}
Expand All @@ -132,6 +137,7 @@ outputs:
- mkl >=2023.2.0 # [x86_64 and not win]
- mkl =2023.1.0 # [x86_64 and win]
- python_abi =3.12
- vc14_runtime =14.42.34433 # [win]
{% endif %}
test:
requires:
Expand Down

0 comments on commit 000b9b5

Please sign in to comment.