Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island Version checking #2109

Closed
17 tasks done
mssalvatore opened this issue Jul 22, 2022 · 0 comments
Closed
17 tasks done

Island Version checking #2109

mssalvatore opened this issue Jul 22, 2022 · 0 comments

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jul 22, 2022

Refactor

Component(s) to be refactored

  • monkey_island.cc.resources.version_update
  • monkey_island.cc.services.version_update

Tasks

  • Add a new object called Version with attributes: (0d) @ilija-lazoroski
    • version_number - Passed in to Version() constructor
    • latest_version - A property that is populated asynchronously upon construction
    • download_url- A property that is populated asynchronously upon construction
  • Construct Version() at Island startup (0d) @ilija-lazoroski
  • Rename VersionUpdate to Version (0d) @ilija-lazoroski
    • Rename /api/version-update to /api/island/version
    • Rename VersionUpdate to Version
    • Rename resources/version_update.py to resources/version.py
  • Use Version object in /api/island/version endpoint (0d) @ilija-lazoroski
    • Add Version object to DIContainer
    • Rename newer_version to latest_version
    • Rename current_version to version_number
    • Modify the UI to compare version_number to latest_version
    • Add Version to resources/__init__.py and shorten all imports
  • Remove services/version_update.py (0d) @ilija-lazoroski
  • Add authentication to /api/island/version. There are comments stating that the UI needs to know the version number before authentication, but I don't know why that's the case. (0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants