Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain related recommendations should not show up if empty #213

Closed
danielguardicore opened this issue Nov 21, 2018 · 4 comments · Fixed by #304
Closed

Domain related recommendations should not show up if empty #213

danielguardicore opened this issue Nov 21, 2018 · 4 comments · Fixed by #304
Assignees
@ShayNehmad
Labels
Beginner friendly New to the project? This issue is good for you!

Comments

@danielguardicore
Copy link
Contributor

Describe the bug
We always display domain related recommendations even if no such issues exist.

To Reproduce
Steps to reproduce the behavior:

  1. Run monkey
  2. Generate report
  3. See error

Expected behavior
Heading should not show up
@danielguardicore danielguardicore added island Beginner friendly New to the project? This issue is good for you! labels Nov 21, 2018
Dhayalanb added a commit to Dhayalanb/monkey that referenced this issue Mar 12, 2019
@Dhayalanb
Update ReportPage.js
53f12f4 
Fix for issue guardicore#213
@Dhayalanb
Copy link
Contributor

@danielguardicore @itaymmguardicore @MaorCore
Deployed a fix by checking if the object is empty before displaying domain related recommendations

{Object.keys(this.state.report.recommendations.domain_issues).length !=0 ? <h3>Domain related recommendations</h3> : null }

@danielguardicore
Copy link
Contributor Author

Thanks, please open this as a PR

Dhayalanb added a commit to Dhayalanb/monkey that referenced this issue Mar 13, 2019
@Dhayalanb
Update ReportPage.js
7eaeef6 
Fix for issue guardicore#213
@Dhayalanb Dhayalanb mentioned this issue Mar 13, 2019
Merged
@ShayNehmad ShayNehmad mentioned this issue Apr 16, 2019
Merged
2 tasks
@ShayNehmad
Copy link
Contributor

@Dhayalanb fixed this based on your PR - you can see it here #304

Thanks a lot! 🏆

@Dhayalanb
Copy link
Contributor

@ShayNehmad Glad to be of help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShayNehmad ShayNehmad

Labels
Beginner friendly New to the project? This issue is good for you!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pr/278 guardicore/monkey
5 participants
@Dhayalanb @danielguardicore @itaymmguardicore @MaorCore @ShayNehmad